Skip to content

remove code duplication in Command.Run functions #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

remove code duplication in Command.Run functions #1077

merged 3 commits into from
Apr 3, 2025

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Dec 27, 2024 •
edited
Loading

Closes #1072

@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch from 9514442 to ce35718 Compare December 27, 2024 09:37
@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch 3 times, most recently from b528063 to cb2e51a Compare March 7, 2025 09:44
@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch 6 times, most recently from 9dbde26 to 7a7758b Compare March 18, 2025 21:11
@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch 2 times, most recently from 495c308 to 75ec3dd Compare March 28, 2025 11:58
@elhimov elhimov marked this pull request as ready for review March 28, 2025 12:04
@elhimov elhimov added the full-ci Enables full ci tests label Mar 28, 2025
@elhimov elhimov marked this pull request as draft March 29, 2025 08:00
@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch 2 times, most recently from d07368c to 6a02599 Compare March 29, 2025 12:17
@elhimov elhimov marked this pull request as ready for review March 29, 2025 12:17
patapenka-alexey
patapenka-alexey reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!
Please, squash commits after the second reviewer and I will approve.

@elhimov
Copy link
Contributor Author

elhimov commented Mar 31, 2025

Thank you for the patch! Please, squash commits after the second reviewer and I will approve.

Sorry, but what's the point? I did split the changes into the separate commits according to the nature of the changes. Why should I squash them?

@oleg-jukovec
Copy link
Contributor

Please, add: Part of #1072 to the commit messages.

@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch from 6a02599 to e965001 Compare April 1, 2025 06:29
@elhimov
Copy link
Contributor Author

elhimov commented Apr 1, 2025

Please, add: Part of #1072 to the commit messages.

Done.

@elhimov elhimov force-pushed the elhimov/gh-1072-remove-code-duplication-in-command-run branch from e965001 to 086f38e Compare April 3, 2025 10:57
@dmyger dmyger merged commit b3870d0 into master Apr 3, 2025
24 checks passed
@dmyger dmyger deleted the elhimov/gh-1072-remove-code-duplication-in-command-run branch April 3, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@patapenka-alexey patapenka-alexey patapenka-alexey approved these changes

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove code duplication in Command.Run functions.
4 participants
@elhimov @oleg-jukovec @patapenka-alexey @dmyger